Add check assert_type to tests for frame.py and add __new__ method for DatetimeIndex #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
commented
Aug 10, 2025
Dr-Irv
reviewed
Aug 11, 2025
Dr-Irv
requested changes
Aug 12, 2025
pandas-stubs/core/frame.pyi
Outdated
Comment on lines
290
to
298
| class _iAtIndexerFrame(_iAtIndexer, Generic[_T]): | ||
| def __getitem__(self, idx: tuple[int, int]) -> Scalar: ... | ||
| def __setitem__( | ||
| self, | ||
| idx: tuple[int, int], | ||
| value: Scalar | NAType | NaTType | None, | ||
| ) -> None: ... | ||
|
|
||
| class _AtIndexerFrame(_AtIndexer, Generic[_T]): |
There was a problem hiding this comment.
since none of the methods in either of these refer to _T, you can remove the Generic part.
There was a problem hiding this comment.
Correct, I had duplicated the _LocIndexerFrame and was removing unused section but forgot about it.
pandas-stubs/core/frame.pyi
Outdated
| def at(self): ... # Not sure what to do with this yet; look at source | ||
| def at( | ||
| self, | ||
| ) -> _AtIndexerFrame: ... # Not sure what to do with this yet; look at source |
pandas-stubs/core/frame.pyi
Outdated
| def iat(self): ... # Not sure what to do with this yet; look at source | ||
| def iat( | ||
| self, | ||
| ) -> _iAtIndexerFrame: ... # Not sure what to do with this yet; look at source |
tests/test_frame.py
Outdated
Comment on lines
3383
to
3384
| df7: pd.DataFrame = pd.DataFrame({"x": [1, 2, 3]}, index=pd.Index(["a", "b", "c"])) | ||
| index: pd.Index = pd.Index(["b"]) |
There was a problem hiding this comment.
should remove the : pd.DataFrame and : pd.Index from this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up tests in tests/test_frame.py as there was no check assert_type in many places.
Added a new method for DatetimeIndex since it would not instantiate to DatetimeIndex but to Series[int].
assert_type()to assert the type of any return value